Add builds for debian13 static, base, base-nossl #1850
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @loosebazooka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces new preview builds for Debian 13 based distroless images, specifically for the static, base, and base-nossl variants. The changes involve updating the build configuration to include these new distributions and modifying the README.md to document their availability and clearly state their preview status, indicating they are intended for testing and may undergo further changes before stabilization.
Highlights
- New Debian 13 Preview Builds: Adds support for building
static,base, andbase-nossldistroless images based on Debian 13, expanding the available image variants. - Documentation Update for Preview Images: Updates the
README.mdto include a new section detailing the Debian 13 preview images, clearly stating their unstable nature and purpose for early testing by users. - Build Configuration Update: Modifies the
BUILDfile to incorporatePREVIEW_DISTROSinto the image generation process for static, base, and base-nossl images, enabling the creation of Debian 13 variants alongside existing distributions.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request adds builds for Debian 13 for static, base, and base-nossl images, and appropriately documents them as 'preview' in the README. The changes in the BUILD file correctly enable the new builds, and the README.md update clearly communicates the preview status and availability of these new images. I have one suggestion for the BUILD file to address code duplication, which could improve long-term maintainability.
|
🌳 🔄 Image Check |
|
Shouldn't we upgrade rules_distroless and enable mergedusr for trixie as mentioned https://github.com/GoogleContainerTools/distroless/blob/main/private/repos/deb/deb.MODULE.bazel#L21 |
|
@loosebazooka Would you mind adds riscv64 architecture into 13? Thanks. |
|
There is https://registry.bazel.build/modules/rules_distroless/0.5.3 which can be bumped here. |
|
@thesayyn I can't seem to bump rules_oci without some modification about where crane is being pulled from |
this was bumped in #1853 |
|
for mergedusrfs, I think we need to
|
|
Any updates on this? :) |
|
@loosebazooka can i help with somethig? |
|
@bobcallaway When will this PR be merged? Happy to contribute where needed. |
Also mention they are in preview in README These builds include merged usrfs, so consumers need to be aware that they - must respect symlinks - users of rules_distroless should enable mergedusr Signed-off-by: Appu Goundan <[email protected]>
loosebazooka
force-pushed
the
add-13-build
branch
from
98c5ea5 to
878fdaf
Compare
|
Updated this to include merged usrfs, I think we can do this build and lets users try it out. I checked manually that the build doesn't overwrite the symlinks anywhere. This may be different with the language images, but we can start from here. @bobcallaway @thesayyn , this is ready for review now? |
|
Thanks for adding Debian 13 builds for static/base! Do you have an ETA for cc and the language images (Python, Java, Node)? |
|
no ETA, but hopefully soon |
9 participants
Also mention they are in preview in README